-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Revolut] Support importing the fees #115
Conversation
This work uses tarioch#105 by Dr-Nuke
As I kept investigating about this, I came up with an alternative: A line of the Revolut CSV is turned into two transactions:
an example:
This allows for the What are your thoughts, @tarioch ? |
I think the split keeps it simple to work with smart importer and I don't have a better idea, let's use that. |
@alvarogarcia7 do you want me to merge it like this or do you want to change it into the split transactions? |
I have submitted the change in code, to add the fee as a new transaction. |
May I suggest to squash the changes, to actually lose the intermediate history? |
Status:
|
I think there is now a pre-commit failure with the latest changes, if you can fix that, I think we can merge it. Honestly I keep the tests a bit limited in here (I have some real data based tests for some of the importers in my personal repo). I think it's ok not to add a test for it. |
Support importing the fees from Revolut.
Based on #105 by @Dr-Nuke
Status:
smart_importer
. See belowUsage
When creating the Revolut Importer, pass an optional parameter
fee
:Smart Importer,
As discussed in #105, when the transaction has more than one posting, smart import won't work anymore.
Proposed workflow:
fee
; then apply smart import.fee
O(n)
, wheren
is the number of entries on the CSV file.If you would be so kind to guide me along those lines, I'll be happy to implement such workflow.